cmake: add missing lib_lightgbm_swig.so to lightgbmlib.jar on linux #6515
Conversation
shuttie
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
|
The failure on |
There was a problem hiding this comment.
Thanks very much for the help!
The SWIG builds here haven't been very actively developed (https://github.com/microsoft/LightGBM/commits/master/swig), and the only tests we run on them is just "does compilation succeed".
Lines 83 to 95 in f811c82
If you have ideas for improving that, we'd welcome the help! For example, I think a some Java unit tests (even just very minimal ones that train a small regression model and maybe generate some predictions) would have caught this bug, and would catch future bugs before they make it to a release. We don't really have much Java experience on the maintainer team, so we'd welcome the help adding something like that (in later PRs) if it interests you.
A PR [cmake] [swig] use CMake's built-in file-copying mechanisms instead of 'cp' #6259 introduced a small build regression:
lib_lightgbm.soandlib_lightgbm_swig.sowere included into the JARlib_lightgbm.sois part of the JAR.Lack of the SWIG wrapper makes it impossible to link to the library from the JVM. Mac and Windows builds do include the SWIG wrapper properly and are not affected by this regression.
This PR adds back the
lib_lightgbm_swig.solibrary to the JAR build process on Linux. I'm maintaining the lightgbm4j library and find it very convenient to re-use your build artifacts :)